This file wasn't included.

"Ticket-based"

Rather than say to only use it with Perforce, I'd like to see some new logic in templates/admin/scmtools/repository/change_form.html to dynamically show/hide this form, like we do with the hosting settings.

I'm not sure I want to add repository-specific fields. What I would like to do, and now is a good time to do it I suppose, is add a "metadata" or "extra_config" (or something) JSONField where we can store additional data like this. That would be more expansive and even allow tools to store additional data per-repository, which could be very useful down the road.

Should be alphabetical.

This might end up causing a lot of spew.

I think we used to have this but that there was some incompatibility with a version of P4API. I'm not sure. I'm going to have to see if David remembers the story here.

Blank line between these.

Florian, does this change REQUIRE you use ticket based auth?  When I looked at it a few days ago, it kind of seemed that way, but haven't had time to dig in.

Right now we simply enter the ticket into our user password.  It would seem easier to have something automated, so I am interested in this change.

Make sure your branch is merged or rebased onto master. That's likely why the additional changes are on there.

I believe it will cause performance issues on the ticked based authentication P4 servers.
I tested on my server, it's much slower than before. And I'm also surprised that it's faster after I moved these into self._connect(). In fact, I find out that run_login is just need in get_file() on my server.
Please check again.

I'd prefer to this:
def _login(self):
        if repository.metadata.get('ticket_based_auth', False) and \
           self.p4.user and self.p4.password:
            self.p4.run_login()

def _connect(self):
        if not self.p4.connected():
            self.p4.connect()
            self._login()

Meanwhile need to remove all self._disconnect() calls below except in __del__().
Thus the performance is much better.

Good idea for new P4API.

Can you document this briefly?

Add a trailing comma.

initial=True? Not sure that makes any sense at all.

"Ticket-based"

"Perforce"

Should be removed.

Should use spaces for indentation.

Use parens instead of \

We used to use run_print, but it would output extra blank lines which broke us. I don't feel comfortable making this change without very extensive testing.